removing extra fs calls#62
Merged
arturadib merged 1 commit intoshelljs:masterfrom May 10, 2013
stephenmathieson:extra-fs-calls
Merged
removing extra fs calls#62arturadib merged 1 commit intoshelljs:masterfrom stephenmathieson:extra-fs-calls
arturadib merged 1 commit intoshelljs:masterfrom
stephenmathieson:extra-fs-calls
Conversation
nothing major, but i've removed a bunch of extra `fs.existsSync` and `fs.statSync` calls, which should speed things up a bit. extra calls have been removed from: - `cd` - `ls` - `cp` - `rm` - `mv`
Collaborator
|
Thanks, I'll merge this in. One of my concerns with caching the result of stat/exists is that the file status might change between caching and probing, but I inspected the patch and it seems like the caching is done not too far from probing so that should be OK. We'll see :) |
Author
|
thanks! let me know if anything needs to be changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nothing major, but i've removed a bunch of extra
fs.existsSyncandfs.statSynccalls, which should speed things up a bit. extra calls have been removed from:cdlscprmmv