Make the maximum buffersize 20 MB.#59
Merged
arturadib merged 1 commit intoshelljs:masterfrom May 4, 2013
waddlesplash:master
Merged
Make the maximum buffersize 20 MB.#59arturadib merged 1 commit intoshelljs:masterfrom waddlesplash:master
arturadib merged 1 commit intoshelljs:masterfrom
waddlesplash:master
Conversation
Contributor
Author
|
Note: NodeJS has default be 200K (http://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback) This was obviously too small. |
Collaborator
|
I haven't encountered any problems with stdout going over 200k. Are you experiencing any specific problems? |
Contributor
Author
|
@yurydelendik said this was a problem. |
|
here is the instance where botio is truncating the log to 200k |
arturadib
added a commit
that referenced
this pull request
May 4, 2013
Make the maximum buffersize 20 MB.
Collaborator
|
OK all done, let me know if that fixed things for botio |
|
That helped. It affects on_cmd_xxx.js commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves some hypothetical problems.