Conversation
freitagbr
requested changes
Nov 24, 2016
ava-test/exec.js
Outdated
| shell.exec(`${JSON.stringify(process.execPath)} -e 'console.log(5678);'`, { silent: true }, (code3, stdout3, stderr3) => { | ||
| t.is(code3, 0); | ||
| t.is(stdout3, '5678\n'); | ||
| t.is(stderr3, ''); |
Contributor
There was a problem hiding this comment.
This and the test above can use code, stdout, and stderr and callback arguments.
af3192c to
93f2a05
Compare
freitagbr
approved these changes
Nov 30, 2016
freitagbr
reviewed
Nov 30, 2016
ava-test/exec.js
Outdated
| // | ||
|
|
||
| test('check if stdout goes to output', t => { | ||
| const result = shell.exec(`${JSON.stringify(process.execPath)} -e 'console.log(1234);'`); |
Contributor
There was a problem hiding this comment.
Do the single-quotes work on Windows?
Member
Author
There was a problem hiding this comment.
They might not. I'll change them back and see
Contributor
There was a problem hiding this comment.
It looks like AppVeyor passed now, so I think this solved the issue.
93f2a05 to
3d10253
Compare
Contributor
|
LGTM |
freitagbr
pushed a commit
that referenced
this pull request
Dec 8, 2016
* test: refactor exec tests to AVA * change single quotes to double quotes for Win
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated PR, so double check that I got all the test cases. I'll follow up once I've verified that this translates everything correctly.