Conversation
freitagbr
requested changes
Nov 23, 2016
| import shell from '..'; | ||
|
|
||
| test.beforeEach(() => { | ||
| shell.config.silent = true; |
Contributor
There was a problem hiding this comment.
This line doesn't need to be in beforeEach.
Member
Author
There was a problem hiding this comment.
Let's leave it here. It's harmless to set it to silent repeatedly, and it's safer in case someone accidentally unsets it in one of the tests.
As long as there's some set up to be done in the beforeEach, I think it's better to just leave lines like this in there as well (unless they need to only be performed once).
freitagbr
approved these changes
Nov 23, 2016
Contributor
|
LGTM |
1 similar comment
Member
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated PR, so double check that I got all the test cases. I'll follow up once I've verified that this translates everything correctly.