Conversation
Set up ava as the new test framework. Migrate the tests for the cd command to use the ava framework.
freitagbr
reviewed
Nov 18, 2016
| import path from 'path'; | ||
| import common from '../src/common'; | ||
| import fs from 'fs'; | ||
| import utils from './utils/utils'; |
Contributor
There was a problem hiding this comment.
Can we group these imports together? I like to group node stdlib imports, then dependency imports, then local imports. Something like:
import fs from 'fs';
import path from 'path';
import test from 'ava';
import shell from '..';
import common from '../src/common';
import utils from './utils/utils';
Member
Author
There was a problem hiding this comment.
SGTM. I'll probably also put newline breaks between sections of the imports
Member
Author
There was a problem hiding this comment.
New format:
- core modules (alphabetized)
- npm modules (alphabetized)
- local files (alphabetized, but with
import shell from '..';first because it needs to be loaded before the others)
package.json
Outdated
| "eslint-config-airbnb-base": "^3.0.0", | ||
| "eslint-plugin-import": "^1.11.1", | ||
| "coffee-script": "^1.10.0", | ||
| "jscodeshift": "^0.3.28", |
Contributor
There was a problem hiding this comment.
Is this dependency necessary? I thought it was used to convert our tests to ava initially, not sure if it's necessary anymore.
Member
Author
There was a problem hiding this comment.
Ah, you're probably right. Thanks for pointing this out. I'll remove it and verify.
Member
Author
|
@freitagbr PTAL |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up ava as the new test framework. Migrate the tests for the cd command to
use the ava framework.
This is the first commit in the plan I suggested in this comment on #512.
Fixes bullet points 1, 2, and 4 of #560