exec options now allows silent:true with callback.#54
Merged
arturadib merged 3 commits intoshelljs:masterfrom Apr 6, 2013
Merged
exec options now allows silent:true with callback.#54arturadib merged 3 commits intoshelljs:masterfrom
silent:true with callback.#54arturadib merged 3 commits intoshelljs:masterfrom
Conversation
Contributor
Author
|
Looks like circular dependency bug in npm https://github.com/isaacs/npm/issues/2063. Hooray jshint now uses shelljs. |
Contributor
Author
|
Looks like Artur believes in hard work :) |
Collaborator
|
Hi sorry I just had time to look at this - would you mind reopening the PR? |
Contributor
Author
|
@arturadib I have re-opened it. I just noticed that some of the changes which I made are already fixed in your master (jshint one). |
Collaborator
|
merged in f7d2e3c - thanks! |
Contributor
Author
|
Thanks for wonderful lib. On Sat, Apr 6, 2013 at 3:08 PM, Artur Adib notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fixed a case when
{silent:true}was defined with callback in exec. I have also added a testcase for this. I also tried to keep JSHint happy.