Conversation
Contributor
|
LGTM! |
Contributor
|
|
Member
Author
|
Huzzah! This comment confirms this. Thanks for pointing this out. In that case, we should eventually revert this PR and use the core API again. It may be worth it to look over where this is used in our code and see if we're falling into any anti-patterns (like checking for a file before reading from it, instead of just reading and catching the exception). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because fs.existsSync is deprecated. This internally uses
fs.statSync()instead, wrapped in a try-catch.