Skip to content

fix(mv): works across partitions#461

Merged
nfischer merged 1 commit intomasterfrom
fix-mv-partitions
Jun 19, 2016
Merged

fix(mv): works across partitions#461
nfischer merged 1 commit intomasterfrom
fix-mv-partitions

Conversation

@nfischer
Copy link
Copy Markdown
Member

Fixes #1

Error reporting seems to work correctly: if an error is encountered at any point, the reported message still indicates it's the mv command that had the error.

I couldn't think of a way to mock tests for this, but let me know if you can think of something.

@nfischer nfischer added fix Bug/defect, or a fix for such a problem low priority labels Jun 14, 2016
@nfischer
Copy link
Copy Markdown
Member Author

I tested this by moving files from my harddrive to a flash drive

@ariporad
Copy link
Copy Markdown
Contributor

ariporad commented Jun 17, 2016

LGTM

I wonder if we could test this with a virtual disk image. (I'm thinking something similar to how mac apps a distributed, like a .dmg file) Or we could maybe use docker.

Docker might be a good idea regardless, I've definitely had some "works on my machine" glitches with shelljs.

@nfischer
Copy link
Copy Markdown
Member Author

Huh? Are we talking about the same thing? This was supposed to be about a bug involving the mv command across disk partitions, not about how we distribute the software.

@ariporad
Copy link
Copy Markdown
Contributor

@nfischer: Yeah. I was thinking that a virtual dist and/or a VMish (like Docker) might work to simulate that for testing.

@nfischer
Copy link
Copy Markdown
Member Author

Is there a simple easy to set that up? This is a pretty obscure edge case. I'd rather not mess with docker as a dev dependency for something like this.

@ariporad
Copy link
Copy Markdown
Contributor

Probably not... Let's forget that for now.

@nfischer
Copy link
Copy Markdown
Member Author

Ok, I'll go ahead and merge this unless there's any objections

@nfischer nfischer merged commit 5d6adba into master Jun 19, 2016
@nfischer nfischer deleted the fix-mv-partitions branch June 19, 2016 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug/defect, or a fix for such a problem low priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants