Conversation
|
I tested this by moving files from my harddrive to a flash drive |
|
LGTM I wonder if we could test this with a virtual disk image. (I'm thinking something similar to how mac apps a distributed, like a .dmg file) Or we could maybe use docker. Docker might be a good idea regardless, I've definitely had some "works on my machine" glitches with shelljs. |
|
Huh? Are we talking about the same thing? This was supposed to be about a bug involving the |
|
@nfischer: Yeah. I was thinking that a virtual dist and/or a VMish (like Docker) might work to simulate that for testing. |
|
Is there a simple easy to set that up? This is a pretty obscure edge case. I'd rather not mess with docker as a dev dependency for something like this. |
|
Probably not... Let's forget that for now. |
|
Ok, I'll go ahead and merge this unless there's any objections |
Fixes #1
Error reporting seems to work correctly: if an error is encountered at any point, the reported message still indicates it's the
mvcommand that had the error.I couldn't think of a way to mock tests for this, but let me know if you can think of something.