Conversation
|
This is admittedly a pretty naive fix, but should get someone who's more familiar with the code base going in the right direction anyway. |
|
hey many thanks for this. I've made some changes to comply with *nix behavior (only create dest dir if it's one level deep), and simplified the logic and tests a bit in cba4f22 (sorry, my editor also removed a bunch of trailing spaces making the diff hard to read) |
|
PS: but your two commits are in the tree of course! :) |
|
Very cool, thanks! :) |
|
Sorry to bring this up again, but when I run shell.js: internal error
Error: ENOENT, no such file or directory 'tmp/dir2/dir3/lib'
at Object.fs.mkdirSync (fs.js:483:18)
at /Users/mstade/Dropbox/dev/stade/shelljs/shell.js:315:14
at Array.forEach (native)
at Object._cp (/Users/mstade/Dropbox/dev/stade/shelljs/shell.js:298:11)
at Object.cp (/Users/mstade/Dropbox/dev/stade/shelljs/shell.js:1080:23)
at Object.<anonymous> (/Users/mstade/Dropbox/dev/stade/shelljs/test/cp.js:139:7)
at Module._compile (module.js:449:26)
at Object.Module._extensions..js (module.js:467:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
*** TEST FAILED! (missing exit code "123")If I comment out the last test block in Here's some machine info, in case it's useful:
|
|
Also, node version:
|
|
Silly me had screwed up the merge of your master into my fork, it's all good. My bad, please ignore! |
|
pheew! :) |
This should fix #44, and get
cpmore inline with its shell counter part. Included tests for the cases mentioned in the issue.