Skip to content

chore: revert depreciate shelljs/make (#431)#458

Merged
nfischer merged 1 commit intoshelljs:masterfrom
just-be-dev:master
Jun 13, 2016
Merged

chore: revert depreciate shelljs/make (#431)#458
nfischer merged 1 commit intoshelljs:masterfrom
just-be-dev:master

Conversation

@just-be-dev
Copy link
Copy Markdown
Contributor

@just-be-dev just-be-dev commented Jun 9, 2016

This reverts commit 5a31c7c from #431.

This reverts the deprecation of the make command as noted in #340.

@just-be-dev just-be-dev changed the title Revert "chore(make): depreciate shelljs/make (#431)" Revert depreciate shelljs/make (#431) Jun 9, 2016
@nfischer nfischer changed the title Revert depreciate shelljs/make (#431) chore: revert depreciate shelljs/make (#431) Jun 9, 2016
@nfischer
Copy link
Copy Markdown
Member

nfischer commented Jun 9, 2016

I'll leave this to @ariporad to review. This commit seems to properly revert the feature, if that's something we want to do.

Alternative approaches would be to display a different warning message instead.

@just-be-dev
Copy link
Copy Markdown
Contributor Author

What different message would be displayed? Unless the deprecation is followed through with I wouldn't think there's a need to have a warning message.

@ariporad
Copy link
Copy Markdown
Contributor

@zephraph: we've decided that this till will be unsupported going forward, so we're going to say something along those lines. Do you want to go ahead and add that, or should I?

@just-be-dev
Copy link
Copy Markdown
Contributor Author

I don't think a message is necessary. Deprioritize it as a feature for support and shift the burden of maintenance onto the community. We could add a message in the documentation to explain as much.

@nfischer
Copy link
Copy Markdown
Member

@zephraph's approach sounds good to me. LGTM

@ariporad
Copy link
Copy Markdown
Contributor

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants