Conversation
Member
Author
|
Update: I removed node v6 from appveyor, since it doesn't seem to be supported yet. |
Contributor
|
Oops... I didn't see this one when opening #434. I'll close that one. |
Contributor
|
Oh, I could review this, couldn't I? |
| assert.ok(!_pwd.stderr); | ||
| assert.equal(shell.error(), null); | ||
| assert.equal(path.basename(_pwd), 'tmp'); | ||
| assert.equal(path.basename(_pwd.toString()), 'tmp'); |
Contributor
There was a problem hiding this comment.
? Why is this here? Seems unrelated.
Member
Author
There was a problem hiding this comment.
It fails without this. In node v6, I believe basename() requires a regular string. If you can get it to pass without this, feel free to change as necessary
Member
Author
|
Yup, feel free to merge if this is good |
Contributor
|
LGTM. Being real smart today I am. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like node v6 just got released. Just tried this out via nvm and saw that one of our tests broke for node v6, so I fixed that test.
Not sure if appveyor can test against node v6 yet, but I added it to the mix anyway.