Fix single/double quotes in exec#42
Merged
arturadib merged 2 commits intoshelljs:masterfrom Dec 1, 2012
danielepolencic:master
Merged
Fix single/double quotes in exec#42arturadib merged 2 commits intoshelljs:masterfrom danielepolencic:master
arturadib merged 2 commits intoshelljs:masterfrom
danielepolencic:master
Conversation
Collaborator
|
hi superb - any chance you can create a test for this in |
Contributor
Author
|
I made the test. this string becomes with the old escaping function, but stays the same the the new one. |
Collaborator
|
superb thanks, and sorry for the delay! |
arturadib
added a commit
that referenced
this pull request
Dec 1, 2012
Fix single/double quotes in exec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when exec runs a command with quotes and double quotes, the old escape function escaped everything as double quotes. E.g.
exec( "curl -XPUT 'http://localhost:9200/index/node' -d '{"key":"value"}' " )
becomes
and the new script fails. The new escape function adds backslashes (like PHP addslashes).
Should hopefully fix Issue #11