Conversation
Contributor
|
LGTM! |
Member
Author
|
LGTM. Merging since this is fairly trivial |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #332
This is pretty straightforward. The issue existed on v0.6, but not on master. This just adds the tests to make sure we don't run into this issue again.
In case you're wondering, the "only -f" case is indeed bash-compatible.
rm -f real_dir/is an error,rm -f fake_dir/is not (assuming thatfake_dir/does not exist, of course).Feel free to adjust the tests as necessary. I checked them against bash on Linux, and this is compatible with that.