refactor(string): modify string protoype, but only for shelljs/global#401
Merged
refactor(string): modify string protoype, but only for shelljs/global#401
Conversation
`require('shelljs/global')` extends String.prototype to have the `.to()` and
`.toEnd()` methods again. This also adds tests for the global require.
Contributor
|
LGTM! |
ariporad
added a commit
that referenced
this pull request
Mar 19, 2016
refactor(string): modify string protoype, but only for shelljs/global
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require('shelljs/global')extends String.prototype to have the.to()and.toEnd()methods again. This also adds tests for the global require.This is along the lines of the discussion in #398. The advantage of this is that ShellJS is still backwards compatible for
require('shelljs/global'), but we still have an option to avoid extending the String prototype (just userequire('shelljs')instead). This would make things more convenient (andglobalis a convenience script primarily), and would ease the transition to ShellJS v0.7.