Skip to content

docs: add link to wiki page#392

Merged
ariporad merged 3 commits intomasterfrom
docs
Mar 20, 2016
Merged

docs: add link to wiki page#392
ariporad merged 3 commits intomasterfrom
docs

Conversation

@nfischer
Copy link
Copy Markdown
Member

Pretty trivial change, just wanted to see what @ariporad thinks of it. It gives a shoutout to the two most popular projects in the wiki.

README.md Outdated
For a non-programmatic implementation of Unix shell commands on top of Node.js, check out [Cash](https://github.com/dthree/cash).
Think ShellJS is cool? Check out some related projects (like
[cash](https://github.com/dthree/cash)--a javascript-based POSIX shell--or
[shx](https://github.com/shelljs/shx)--ShellJS functions exposed straight to
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  1. I think the wiki page should be a separate item.
  2. I feel like shx should get it's own section. Maybe just a little intro.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariporad could you rewrite this PR to clarify what you mean?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nfischer: Done. (I made it a separate commit so you could compare the changes, I'll squash them if you like them).

@nfischer
Copy link
Copy Markdown
Member Author

@ariporad I rebased this. I changed the wording a little bit. I also removed the docs for the make command, and moved these to the wiki (and a link is provided). The rationale behind this is that I want less junk in the way of the command reference, which is probably the most important part of the README.

@ariporad
Copy link
Copy Markdown
Contributor

LGTM!

ariporad added a commit that referenced this pull request Mar 20, 2016
docs: add link to wiki page
@ariporad ariporad merged commit d8af30e into master Mar 20, 2016
@ariporad ariporad deleted the docs branch March 20, 2016 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants