Conversation
4a2e13c to
3169338
Compare
Member
Author
|
@ariporad can you take a look at this? Let me know what you think, or if there's any other perf improvements we can squeeze out. |
3169338 to
4f9595a
Compare
| shell.config.silent = true; | ||
|
|
||
| shell.rm('-rf', 'tmp'); | ||
| shell.mkdir('tmp'); |
Contributor
There was a problem hiding this comment.
Why is this here? It seems completely unrelated.
Member
Author
There was a problem hiding this comment.
One of the tests assumed incorrect semantics of cp(). When I fixed the semantics, I realized this test was failing.
The directory actually gets created with a cp() command on this line
Contributor
|
@nfischer: One tiny nit, and could you please rebase off |
Contributor
|
@nfischer: Can you rebase of master? Otherwise LGTM! |
Fixes issue in #376. Simplifies the code, and slight perf win.
4f9595a to
4b951ce
Compare
Member
Author
|
@ariporad I just re-pushed |
ariporad
added a commit
that referenced
this pull request
Mar 6, 2016
refactor(cp): clean up code and fix #376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue in #376. Simplifies the code, and slight perf win.
This fixes the semantics of
cp(), which had deviated from unixcpa bit. If anyone is available to review, that would be good.Goals of this PR: