Skip to content

feat(touch): supports multiple files#346

Merged
ariporad merged 1 commit intomasterfrom
touch-multiple-files
Feb 16, 2016
Merged

feat(touch): supports multiple files#346
ariporad merged 1 commit intomasterfrom
touch-multiple-files

Conversation

@nfischer
Copy link
Copy Markdown
Member

@nfischer nfischer commented Feb 9, 2016

Does what it says. From the (updated) docs:

touch([options,] file [, file ...])
touch([options,] file_array)

This is consistent with the API for ls(), cp(), mv(), rm(), etc.

@nfischer nfischer added feature medium priority bash compat Compatibility issues with bash or POSIX behavior labels Feb 9, 2016
@nfischer nfischer added this to the v0.7.0 milestone Feb 9, 2016
src/touch.js Outdated
} else {
if (!files)
common.error('no files given');
else if (Array.isArray(files))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to do a no-op. For what it's worth, I think #352 will make this line obsolete, so we might want to wait until that's merged

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nfischer: Ok, #352 is merged.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase and update this tonight or tomorrow. Thanks!

@nfischer nfischer force-pushed the touch-multiple-files branch from d99524a to 19721fc Compare February 16, 2016 17:59
@nfischer
Copy link
Copy Markdown
Member Author

@ariporad this should be fixed now

@ariporad
Copy link
Copy Markdown
Contributor

LGTM! Will merge once Travis is done.

@ariporad
Copy link
Copy Markdown
Contributor

LGTM!

ariporad added a commit that referenced this pull request Feb 16, 2016
feat(touch): supports multiple files
@ariporad ariporad merged commit bceac92 into master Feb 16, 2016
@ariporad ariporad deleted the touch-multiple-files branch February 16, 2016 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bash compat Compatibility issues with bash or POSIX behavior feature medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants