fix(touch): enhance parseOptions and fix touch's -r flag#341
Merged
Conversation
src/common.js
Outdated
| var optionName; | ||
| if (typeof opt === 'string') { | ||
| // e.g. match[1] = 'Rf' for opt = '-Rf' | ||
| var match = opt.match(/^\-(.+)/); |
Contributor
There was a problem hiding this comment.
This would be much more performant if it just was opt[0] === '-'.
Contributor
|
One small nit, otherwise looks good! |
Contributor
|
@nfischer: In the changelog, how should this be described? |
5434a0e to
dc79d7e
Compare
Member
Author
|
@ariporad I replaced the instances of |
Contributor
|
@nfischer: Fantastic! |
Member
Author
|
In the changelog, you can just say something like "feat: now supports valued options (see |
Contributor
|
Will Do! |
Contributor
|
LGTM! |
ariporad
added a commit
that referenced
this pull request
Feb 5, 2016
fix(touch): enhance parseOptions and fix touch's -r flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves
parseOptionsto allow options of the form:to supply a value to an option. In this example,
-rhas the string value'path/to/file'.