Conversation
Contributor
Author
|
@nfischer: Ready for review. |
.npmignore
Outdated
| test/ | ||
| tmp/ No newline at end of file | ||
| tmp/ | ||
| scripts/ |
Contributor
Author
There was a problem hiding this comment.
@nfischer: I suppose we could, but I can't think of a reason anyone who downloads it from npm would ever need them, so I thought we may as well save them the bytes.
Member
There was a problem hiding this comment.
I guess the only reason is so that they can run tests to verify their build works. It might be helpful for debugging someone's problems
d8ddcb2 to
fb574eb
Compare
fb574eb to
3e22277
Compare
Contributor
Author
|
@nfischer: should be fixed now. |
Member
|
LGTM |
nfischer
added a commit
that referenced
this pull request
Feb 4, 2016
chore(.npmignore): update npmignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.