Conversation
src/set.js
Outdated
Contributor
There was a problem hiding this comment.
Why not just always prepend '-' here, and register th
Member
Author
There was a problem hiding this comment.
Yeah, I can edit it to do that. I still need to get the negate boolean anyway.
Contributor
There was a problem hiding this comment.
@nfischer: No, I realized that what I meant wouldn't work. Never mind.
Add new set() command as a wrapper for `config` variables. This takes the `-e`, `-v`, `+e`, and `+v` flags.
ac29259 to
ca045ea
Compare
Member
Author
|
@ariporad this should be ready |
Contributor
|
Oops, LGTM!
|
Member
Author
|
I'll merge once CI passes |
nfischer
added a commit
that referenced
this pull request
Feb 1, 2016
feat(set): add new set() command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new set() command as a wrapper for
configvariables. This takes the-e,-v,+e, and+vflags.This is based off (and replaces) #149, which introduced the
logCmdoption. This also addsset()as a nice wrapper for interfacing with the variables.config.verbosewill log each command in a unix-y kind of format. For example,ls('dir/')logs asls dir/(strips parens, strips surrounding quotes). This is mostly just because it was easier to implement this way.I left the docs for
config.fatal(and added docs forconfig.verbose), although we might also consider deprecating those and encouraging the use of the equivalentset()commands instead (to trim down on documentation). One issue is thatconfig.silentdoes not have an analogoussetoption.This also fixes a formatting error in
touch.js's comment block.