Fix symlinking on Windows#322
Merged
ariporad merged 1 commit intoshelljs:masterfrom Jan 31, 2016
BYK:linking-windows
Merged
Conversation
Contributor
Author
|
Gonna fox POSIX issues. |
Contributor
Author
|
Okay, should be fixed now. |
Member
|
I haven't tested this on my windows machine, but it looks like it won't break linux/mac behavior, and it definitely looks like an improvement for Windows behavior. Since it passes all the CI, LGTM. |
Fixes symlink creation on Windows systems and adds a test for symlinking directories since it needs special treatment on Windows. Fixes #301.
Contributor
Author
|
Rebased |
Contributor
|
LGTM! |
Contributor
|
Thanks @BYK! |
ariporad
added a commit
that referenced
this pull request
Jan 31, 2016
fix(Windows): fix symlinking on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes symlink creation on Windows systems and adds a test
for symlinking directories since it needs special treatment
on Windows.
Fixes #301.