Skip to content

Rewrite .gitignore to be more comprehensive#321

Merged
nfischer merged 1 commit intoshelljs:masterfrom
BYK:ignore-idea
Jan 31, 2016
Merged

Rewrite .gitignore to be more comprehensive#321
nfischer merged 1 commit intoshelljs:masterfrom
BYK:ignore-idea

Conversation

@BYK
Copy link
Copy Markdown
Contributor

@BYK BYK commented Jan 29, 2016

Ignores more Node/NPM files and adds ignore rules for the following:

  • Linux
  • OS X
  • Vim
  • JetBrains IDEs

@nfischer
Copy link
Copy Markdown
Member

I think it would be more useful to have one PR that ignores basic ignore files, like in swap files and such as well. I can write that out, but you're more than welcome to add them yourself

@nfischer
Copy link
Copy Markdown
Member

I think adding these should be good enough:

# Mac files
.DS_Store

# Vim files
[._]*.s[a-w][a-z]
*~

@nfischer nfischer self-assigned this Jan 30, 2016
@nfischer nfischer added the chore label Jan 30, 2016
@BYK BYK changed the title Ignore IntelliJ files Rewrite .gitignore to be more comprehensive Jan 30, 2016
@BYK
Copy link
Copy Markdown
Contributor Author

BYK commented Jan 30, 2016

Well, since you asked for it, I did a much more comprehensive edit (a rewrite at this point) on the file. Updated the commit and PR messages accordingly. What do you think?

@nfischer
Copy link
Copy Markdown
Member

@BYK this might be a little too much for my taste. I think less is more. We haven't had an issue of accidentally committing editor files, so it may be best to put this off until the problem arises.

@BYK
Copy link
Copy Markdown
Contributor Author

BYK commented Jan 31, 2016

@nfischer - alright, removed a bunch of stuff. What do you think? :)

Ignores more Node/NPM files and adds ignore rules for the following:

- Linux
- OS X
- Vim
- JetBrains IDEs
@ariporad
Copy link
Copy Markdown
Contributor

@BYK: Hmm... What about gitignore.io?

That would probably be more comprehensive, but I'm not really super strict either way. So LGTM. @nfischer: What do you think? I'm happy either way, so feel free to merge.

@nfischer
Copy link
Copy Markdown
Member

LGTM

nfischer added a commit that referenced this pull request Jan 31, 2016
Rewrite .gitignore to be more comprehensive
@nfischer nfischer merged commit 760c191 into shelljs:master Jan 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants