Conversation
5b58cde to
d4e6adc
Compare
This is an example PR for how to make PRs against #317.
|
@ariporad is this up to date with master? It looks like it's failing Windows CI. Also, it looks like something is undefined in |
|
@nfischer: It's up to date with master, but the lint stage is failing _badly_ |
|
@nfischer: Oh, actually, |
This is an example PR for how to make PRs against #317.
|
@ariporad I changed the milestone, since I don't think we should push off 0.6 just so we can switch lint tools |
.eslintrc
Outdated
There was a problem hiding this comment.
We should prefer .eslintrc.json as the file name. "raw" .eslintrc files are deprecated.
|
I'm willing to help with this. Have you tried using the |
|
@BYK: Oops... I forgot about that. |
This is an example PR for how to make PRs against #317.
|
@BYK: Fixed. |
|
Adding the following to the rule set helps a lot: |
This is an example PR for how to make PRs against #317.
This is an example PR for how to make PRs against #317.
|
Looks like this is the problem: |
|
FYI I didn't try to fix all warnings so the warnings are expected. Also I'm not sure AirBnB style guide was a good choice since it looks a bit too browser oriented. |
lol - sorry for not following this :D |
|
Don't worry, it didn't end up making a difference. |
|
Umm… is there a reason why this is high priority? |
|
I feel like this should be a low priority issue. Lengthy chores probably shouldn't be high priority. I think only in-demand features and bug fixes (and issues blocking those) should be high priority |
|
Oh, yeah, that was a mistake. Fixed. |
|
@ariporad any further work on this? This might be nice to start transitioning to using. |
This PR switches us from JSHint to ESLint.
ESLint checks both lint errors and style.
We're using AirBnB's Style Guide as a starting point.
Since there are about 1700 lint errors, which I couldn't possibly hope to do myself, this PR is going to be done slightly differently. While this PR will remain open, Me and @nfischer will accept PRs against _this_ branch fixing a small number of lint errors (Please do one file per PR). Then, once the number of lint errors is 0, we'll squash everything and merge into master.
Current Lint Problem Count for this branch:
794