Skip to content

fix(windows): fix shjs commands for windows#315

Merged
ariporad merged 1 commit intomasterfrom
fix-shjs-test
Jan 28, 2016
Merged

fix(windows): fix shjs commands for windows#315
ariporad merged 1 commit intomasterfrom
fix-shjs-test

Conversation

@nfischer
Copy link
Copy Markdown
Member

Prefix shjs commands withnode for Windows, since Windows doesn't use shebangs.

Blocks #297

@nfischer nfischer added fix Bug/defect, or a fix for such a problem Windows labels Jan 27, 2016
@nfischer nfischer added this to the v0.6.0 milestone Jan 27, 2016
@nfischer nfischer mentioned this pull request Jan 27, 2016
@nfischer
Copy link
Copy Markdown
Member Author

@ariporad I think it's ok to merge this with the broken tests, since it fixes one of them (and then #297) should be safe to merge.

@ariporad
Copy link
Copy Markdown
Contributor

LGTM!

ariporad added a commit that referenced this pull request Jan 28, 2016
fix(windows): fix shjs commands for windows
@ariporad ariporad merged commit a67f66a into master Jan 28, 2016
@ariporad ariporad deleted the fix-shjs-test branch January 28, 2016 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug/defect, or a fix for such a problem Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants