Skip to content

chore(LGTM): add LGTM config files#312

Merged
nfischer merged 1 commit intoshelljs:masterfrom
ariporad:LGTM
Jan 26, 2016
Merged

chore(LGTM): add LGTM config files#312
nfischer merged 1 commit intoshelljs:masterfrom
ariporad:LGTM

Conversation

@ariporad
Copy link
Copy Markdown
Contributor

@nfischer: Could you review?

@ariporad
Copy link
Copy Markdown
Contributor Author

LGTM

@nfischer
Copy link
Copy Markdown
Member

👍

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need approvals = 1?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll fix that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nfischer: Fixed.

@nfischer
Copy link
Copy Markdown
Member

@ariporad I just have one comment about the approvals count

@ariporad
Copy link
Copy Markdown
Contributor Author

@nfischer: Fixed. Feel free to merge.

nfischer added a commit that referenced this pull request Jan 26, 2016
chore(LGTM): add LGTM config files
@nfischer nfischer merged commit c1813c2 into shelljs:master Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants