test(shjs): add tests for shjs#304
Merged
nfischer merged 1 commit intoshelljs:masterfrom Jan 25, 2016
Merged
Conversation
Contributor
Author
|
@nfischer: ready for review. |
Member
There was a problem hiding this comment.
Can we add a test with return code 0?
Member
There was a problem hiding this comment.
(or just see my comment below)
Member
|
Could we add a test to make sure it correctly infers the file extension? Perhaps |
Member
|
Other than that, LGTM |
681d163 to
b60ab70
Compare
Contributor
Author
|
@nfischer: Should have fixed all those, feel free to re-review/merge. |
nfischer
added a commit
that referenced
this pull request
Jan 25, 2016
test(shjs): add tests for shjs
Member
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #280.