fix: jshint works on Windows#295
Merged
ariporad merged 2 commits intoshelljs:masterfrom Jan 21, 2016
nfischer:fix-run-tests
Merged
fix: jshint works on Windows#295ariporad merged 2 commits intoshelljs:masterfrom nfischer:fix-run-tests
ariporad merged 2 commits intoshelljs:masterfrom
nfischer:fix-run-tests
Conversation
run-tests.js previously relied on shell wildcard expansion, and did not specify full paths. This uses common.expand to handle globbing internally, and specifies the full path, so jshint can find all the files.
Member
Author
|
Update: I fixed the lint errors in |
Member
Author
|
@ariporad is this safe to merge? |
Contributor
|
LGTM! |
Contributor
|
@nfischer: This gave me an idea (if you like it, I'll open a separate issue): What if we wrote an |
Member
Author
|
@ariporad I don't have much experience with eslint. That sounds like it'd be useful though (since it can be somewhat annoying to declare in a comment which globals are used). I think this project relies on jshint partially because it uses shelljs as a dependency. So far, it seems fairly easy to stick with jshint, so I say we don't prioritize the switch too much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run-tests.jspreviously relied on shell wildcard expansion, and did not specifyfull paths. This uses common.expand to handle globbing internally, and specifies
the full path, so jshint can find all the files.
This does not entirely fix
run-tests, but this does fix the jshint portion, so we'll at least get it to process javascript files. A full fix would be much more intensive, sinceexec()can't start from the current working directory. So this is only a partial fix for #294.Also, this adds in lint-checking the
scripts/folder (and fixes the lint errors I found!). Now the only significant folder this skips is thesrc/folder (which I'm working on providing support for).