whoops. the shelljs tests should test for global leaks.

thanks, nice catch.

@aeosynth - yes it'd be nice if we had such a test. ideas welcome :)

ideas welcome

Use a unit testing framework. Is there a design goal to not have any
dependencies?

which unit test framework has global pollution tests built into it?

also it seems to me that most leaks can be caught with a simple test for change in the number of global.* methods

I would think that most frameworks check for global pollution. I know that
mocha does.

It is easy enough to check yourself, but again, why not include a
dependency instead of creating everything from scratch?

haven't had to create anything from scratch yet as most of our unit tests
are one-liners and the prep work would need to be done with any framework.

dependencies introduce breakages beyond our control, so there has to be a
good reason to add one.

this global check looks like just a couple/few lines, but again I'm happy
to consider introducing a framework if there's a clear need for one.

thanks,
-Artur

On Mon, Sep 24, 2012 at 1:06 PM, James Campos notifications@github.comwrote:

I would think that most frameworks check for global pollution. I know that
mocha does.

It is easy enough to check yourself, but again, why not include a
dependency instead of creating everything from scratch?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/29#issuecomment-8826361.

Thanks for your quick response @aeosynth and @arturadib!
I'm using mocha, and it tells me this issue.

Thanks!