update exec docs to match implemented behaviour#289
Merged
nfischer merged 1 commit intoshelljs:masterfrom Jan 14, 2016
vise890:master
Merged
update exec docs to match implemented behaviour#289nfischer merged 1 commit intoshelljs:masterfrom vise890:master
exec docs to match implemented behaviour#289nfischer merged 1 commit intoshelljs:masterfrom
vise890:master
Conversation
Closed
Contributor
|
LGTM! @nfisher: feel free to merge |
nfischer
added a commit
that referenced
this pull request
Jan 14, 2016
update `exec` docs to match implemented behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implementation of #185 (I didn't have the old fork anymore)
The exec docs specify:
That seems to imply to me that the following code can be written:
which prints:
After looking at the code, however, it is clear that
options.asyncis overridden totrueif a callback is provided. This PR updates the README to be more in line with the code. What do you think?