Skip to content

-a includes . and ..; -A does not#28

Merged
arturadib merged 1 commit intoshelljs:masterfrom
aeosynth:lsa
Sep 24, 2012
Merged

-a includes . and ..; -A does not#28
arturadib merged 1 commit intoshelljs:masterfrom
aeosynth:lsa

Conversation

@aeosynth
Copy link
Copy Markdown
Contributor

No description provided.

@arturadib
Copy link
Copy Markdown
Collaborator

nice catch. alas, this would break a bunch of other parts of the code that already rely on the (non-Unix compliant) -a option.

I think the right move would be to add support to both -a and -A, and change all calls of the type _ls('-a', ...) to the -A option within shell.js.

any takers? :)

@aeosynth
Copy link
Copy Markdown
Contributor Author

alas, this would break a bunch of other parts of the code

I fixed up the other parts; all (modified) tests pass.

I think the right move would be to add support to both -a and -A

sure I can do that, but honestly -a is prety useless - it's -A with two extra entries tacked on.

@arturadib
Copy link
Copy Markdown
Collaborator

my bad, didn't read the whole change set.

OK, what I'll do is I'll add a deprecated message for the -a option for users that already depend on it. thanks.

arturadib added a commit that referenced this pull request Sep 24, 2012
-a includes . and ..; -A does not
@arturadib arturadib merged commit eb8ab8a into shelljs:master Sep 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants