Make to and toEnd chainable#276
Merged
ariporad merged 1 commit intoshelljs:masterfrom Jan 25, 2016
TimothyGu:to
Merged
Conversation
Member
|
This seems like a cool potential feature. Is this possible to emulate in Bash though? |
Contributor
|
@nfischer: Apparently (TIL!): $ echo "Apparently this works\!" > foo > bar > baz
$ echo foo
Apparently this works!
$ echo bar
Apparently this works!
$ echo baz
Apparently this works! |
Contributor
|
@TimothyGu: Two things:
|
src/to.js
Outdated
Member
There was a problem hiding this comment.
Would return this; also work? I'm refactoring the ShellString type with the intention that only strings created with common.ShellString will have the .to() and .toEnd() types. This is so that we can avoid modifying the String prototype.
Member
|
I just have one comment that should be addressed before merging |
Contributor
Author
Member
|
LGTM once this passes tests |
ariporad
added a commit
that referenced
this pull request
Jan 25, 2016
feat(end/round): make to and toEnd chainable
Contributor
|
Merged! Thanks @TimothyGu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.