Don't do console.log.apply(this, ...).#274
Merged
nfischer merged 1 commit intoshelljs:masterfrom Jan 15, 2016
Merged
Conversation
Member
|
Could we re-ping this to trigger the CI? |
Member
|
This looks good, but I'd like to verify that it passes the CI before merging. Perhaps we can rebase off master once #267 is merged (since the Aside from that, I expect this to work on both Windows and *nix. |
Member
|
@ariporad if the merge conflicts can be resolved, I can merge this 👍 |
Contributor
Author
|
@nfisher: there are none. Merging EDIT: never mind, caching. I will fix when I'm at a computer |
Member
|
I think the only issue is that I changed a |
Contributor
Author
|
@nfischer: Fixed. |
Member
|
@ariporad Awesome! I'll merge. |
nfischer
added a commit
that referenced
this pull request
Jan 15, 2016
Don't do `console.log.apply(this, ...)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #255.