Fixes an issue with multi-symbolic mode specification (ie a-rwx,u+rw)#227
Merged
arturadib merged 5 commits intoshelljs:masterfrom Aug 29, 2015
Merged
Fixes an issue with multi-symbolic mode specification (ie a-rwx,u+rw)#227arturadib merged 5 commits intoshelljs:masterfrom
arturadib merged 5 commits intoshelljs:masterfrom
Conversation
Collaborator
|
awesome thank you! |
arturadib
added a commit
that referenced
this pull request
Aug 29, 2015
Fixes an issue with multi-symbolic mode specification (ie a-rwx,u+rw)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you call:
shelljs.chmod('a-rwx,u+rw', 'file');
shelljs.chmod('a-rwx,u+rw', 'file');
Then the file will have no permissions (mode 000). This is because the permissions at the beginning of the second call are 600, and when the 'u+rw' is processed, it compares the final mode (600) with the original mode (now outdated due to 'a-rwx', but 600) and does not run the operation if they are the same.
This PR adds a few more multi-symbolic tests, and resets 'perms' to 'newPerms' after running fs.chmodSync() to allow examples like 'a-rwx,u+rw' to work correctly even if the original file permission was already set as desired.