Manually closing streams#222
Merged
arturadib merged 2 commits intoshelljs:masterfrom Aug 11, 2015
JulianLaval:patch-1
Merged
Conversation
|
I fear this could reintroduce the bug that #214 fixed. Perhaps try something like this: var stdoutEnded = false, stderrEnded = false;
function tryClosing() {
if (stdoutEnded && stderrEnded) {
stdoutStream.end();
}
}
childProcess.stdout.on('end', function() {
stdoutEnded = true;
tryClosing();
});
childProcess.stderr.on('end', function() {
stderrEnded = true;
tryClosing();
}); |
Contributor
Author
|
@devtristan, whilst this did not explicitly reintroduce the bug fixed by #214, it was indeed misguided in its reliance on Your solution is much more elegant and relevant; applying your fix + outputting to console on Pull request updated accordingly! |
Collaborator
|
thanks @JulianLaval and @devtristan ! |
Collaborator
|
this is now published in v0.5.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the stream closing issue introduced by pull #214.
According to the Node Docs,
process.stderrandprocess.stdoutare closed when the process exits - we can listen to this and close thestdoutStreamaccordingly