Memoized the result of target invocation#216
Merged
arturadib merged 1 commit intoshelljs:masterfrom Aug 15, 2015
rizowski:returnResult
Merged
Memoized the result of target invocation#216arturadib merged 1 commit intoshelljs:masterfrom rizowski:returnResult
arturadib merged 1 commit intoshelljs:masterfrom
rizowski:returnResult
Conversation
For a current makescript I was unable to use promises as the task had previously ran. This commit returns a result of the target so promises can still resolve but doesn't change the flow of how the make file works.
|
👍 |
Contributor
Author
|
Looks like it is failing on node version 12 but failing to an unrelated change. I don't have permission to rerun the tests. |
|
@arturadib Any progress on this? |
arturadib
added a commit
that referenced
this pull request
Aug 15, 2015
Memoized the result of target invocation
Contributor
|
This is breaking existing functionality for me: I used to have something like: target.build = function () { /* write to a file */ }
target.watch = function () {
onFileChange('*.txt', target.build);
}With this change |
|
This would seem on par with how makefiles work. In general Makefiles only execute each target once. If you wish to invoke a function multiple times then it would be better served as a normal function that is not one of the build targets. An alternative you could use is: |
Collaborator
|
spot-on @mtscout6 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a current make script I was unable to use promises as the task had previously ran.
This commit it makes it so the targets still return a result even if they have been ran. This makes it so that the promises can still be used.