prevent internal error: write after end#214
Merged
arturadib merged 1 commit intoshelljs:masterfrom Aug 10, 2015
charlierudolph:patch-1
Merged
prevent internal error: write after end#214arturadib merged 1 commit intoshelljs:masterfrom charlierudolph:patch-1
arturadib merged 1 commit intoshelljs:masterfrom
charlierudolph:patch-1
Conversation
Contributor
Author
chinthakagodawita
pushed a commit
to chinthakagodawita/docker-hat
that referenced
this pull request
Jul 13, 2015
Contributor
|
+1, can confirm that it fixes #206 Please merge! |
arturadib
added a commit
that referenced
this pull request
Aug 10, 2015
prevent internal error: write after end
Collaborator
|
merged this - but when will the streams be closed now? |
Collaborator
|
this is now published in v0.5.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #206
Was unable to write a reliable test but the following failed about half time without the change and did not fail with the change
I'm convinced this is the appropriate fix based on the documentation as we are piping two readable streams to a writeable stream and if one ends and the other writes later we get a "write after end". The ends of the std streams does not appear to be consistent.