Skip to content

grep() support for globing, fixes #118#119

Merged
arturadib merged 9 commits intoshelljs:masterfrom
utensil-contrib:118-grep-glob
Apr 21, 2014
Merged

grep() support for globing, fixes #118#119
arturadib merged 9 commits intoshelljs:masterfrom
utensil-contrib:118-grep-glob

Conversation

@utensil
Copy link
Copy Markdown
Contributor

@utensil utensil commented Apr 19, 2014

grep() support for globing, such as */*.md or **/*.md. fixes #118 .

@utensil
Copy link
Copy Markdown
Contributor Author

utensil commented Apr 19, 2014

The unfortunate part of this PR is that it introduced the dependency on minimatch.

@utensil
Copy link
Copy Markdown
Contributor Author

utensil commented Apr 20, 2014

Great, now travis is green and dependcy on minimatch is removed.

@arturadib
Copy link
Copy Markdown
Collaborator

awesome, thank you!

arturadib added a commit that referenced this pull request Apr 21, 2014
grep() support for globing, fixes #118
@arturadib arturadib merged commit 8ba50dc into shelljs:master Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

grep() should fully support globing

2 participants