Add -l and -s support to grep.#116
Conversation
|
thanks Scott! for some reason the ordering is coming out different from the expected for Node v0.8 (https://travis-ci.org/arturadib/shelljs/jobs/23311967) so the build is failing.. it's potentially a bug in our grep implementation - it should match whatever Unix's grep does, and I assume it sorts the files before matching? if so we should probably do the same, that way your tests will pass in v0.8 too :) |
|
Ah, yeah. Didn't consider ordering differences when I was testing locally. I can take a look later tonight at beefing that up so it's robust across versions. |
|
hmm not sure why it didn't pass Travis this time, I'll merge it in and see what comes out of the build :) |
Add -l and -s support to grep.
|
had to revert the merge, it didn't pass Travis again :( can you reproduce the issue? I wasn't able to locally.. seems to have something to do with the |
|
Sorry I haven't gotten back to this. Will try to take another look when I get a moment. |
No description provided.