Skip to content

[2.0] Remove deprecated asShape / adapter classes#961

Merged
jorisvandenbossche merged 5 commits intoshapely:shapely-2.0from
jorisvandenbossche:shapely-2.0-remove-adapters
Aug 28, 2020
Merged

[2.0] Remove deprecated asShape / adapter classes#961
jorisvandenbossche merged 5 commits intoshapely:shapely-2.0from
jorisvandenbossche:shapely-2.0-remove-adapters

Conversation

@jorisvandenbossche
Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche commented Aug 11, 2020

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Aug 11, 2020

Coverage Status

Coverage decreased (-0.7%) to 81.964% when pulling 79a2a01 on jorisvandenbossche:shapely-2.0-remove-adapters into f0eed38 on Toblerity:shapely-2.0.

@jorisvandenbossche jorisvandenbossche changed the base branch from master to shapely-2.0 August 18, 2020 06:08
@jorisvandenbossche jorisvandenbossche marked this pull request as ready for review August 26, 2020 21:06
@jorisvandenbossche
Copy link
Copy Markdown
Member Author

Updated / fixed conflicts now the other PR is merged.

@sgillies @mwtoews even more lines to remove here ;)

@sgillies
Copy link
Copy Markdown
Contributor

It's a shame that code coverage goes down because this dubious feature was well tested :)

from .polygon import Polygon, asPolygon
from .multipoint import MultiPoint, asMultiPoint
from .multilinestring import MultiLineString, asMultiLineString
from .multipolygon import MultiPolygon, MultiPolygonAdapter
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪 👋

Copy link
Copy Markdown
Contributor

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

OK, thanks for the review, then I will do my first merge ;)

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

@sgillies hmm, it seems that although I am now a member of the Toblerity organization, I don't yet have "write access" to the Shapely repository. So that's maybe yet another setting?

@sgillies
Copy link
Copy Markdown
Contributor

@jorisvandenbossche ah, right, I did miss the Shapely settings, but you have write perms now.

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

Great, thanks!

@jorisvandenbossche jorisvandenbossche merged commit 464f188 into shapely:shapely-2.0 Aug 28, 2020
@jorisvandenbossche jorisvandenbossche deleted the shapely-2.0-remove-adapters branch August 28, 2020 14:43
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Sep 13, 2020
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Sep 13, 2020
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Nov 27, 2020
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Apr 5, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Apr 5, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request May 27, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request May 27, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Aug 20, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants