BUG: Add casts to GEOSGeom_destroy_r and GEOSGeom_createPolygon_r.#2293
BUG: Add casts to GEOSGeom_destroy_r and GEOSGeom_createPolygon_r.#2293jorisvandenbossche merged 3 commits intoshapely:mainfrom
Conversation
shapely/_geometry_helpers.pyx
Outdated
| g = <GEOSGeometry *>arr[i] | ||
| if g != NULL: | ||
| GEOSGeom_destroy_r(handle, <GEOSGeometry *>arr[i]) | ||
| GEOSGeom_destroy_r(<GEOSContextHandle_t> handle, <GEOSGeometry *>arr[i]) |
There was a problem hiding this comment.
Actually, could you change the void* handle in GEOSContextHandle_t handle in the _deallocate_arr signature a few lines above? That should also fix it and feels better (everywhere we use this helper function, the handler is declared to be a context handle)
There was a problem hiding this comment.
Sure. I'll test it on my local code and do that if it works, but it might be Monday before I get to it
There was a problem hiding this comment.
(small ping, otherwise I can also push myself after the weekend)
There was a problem hiding this comment.
@schwehr updated here (I want to get this out in a 2.1.1 release), going to assume my suggestion is also fixing the original issue you noticed (but please test and let us know if not!)
|
@schwehr thanks for the report and PR! |
…hapely#2293) Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Fixes #2289