BUG: fix Point x/y/z/m attributes to return Python floats#2074
Merged
mwtoews merged 1 commit intoshapely:mainfrom Jul 7, 2024
Merged
BUG: fix Point x/y/z/m attributes to return Python floats#2074mwtoews merged 1 commit intoshapely:mainfrom
mwtoews merged 1 commit intoshapely:mainfrom
Conversation
Pull Request Test Coverage Report for Build 9646980112Details
💛 - Coveralls |
mwtoews
approved these changes
Jun 25, 2024
Member
mwtoews
left a comment
There was a problem hiding this comment.
Looks good, it's consistent how (e.g.) .area is handled from the "Y_d" ufuncs.
And I suppose we'll keep the numpy ufunc return types? E.g. shapely.get_x and shapely.area return numpy.float64.
Member
Author
Yes, for the ufuncs I think we don't want to distinguish based on the input/output dimension, and just let numpy handle that. |
mwtoews
added a commit
to mwtoews/shapely
that referenced
this pull request
Jul 10, 2024
mwtoews
added a commit
that referenced
this pull request
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2070