COMPAT: fix assert_geometries_equal to work with numpy 2.0 copy changes#2007
Merged
jorisvandenbossche merged 1 commit intoshapely:mainfrom Mar 6, 2024
Merged
Conversation
Pull Request Test Coverage Report for Build 8155463209Details
💛 - Coveralls |
This was referenced Mar 5, 2024
mwtoews
approved these changes
Mar 5, 2024
Member
mwtoews
left a comment
There was a problem hiding this comment.
Thanks! I see the upstream change numpy/numpy@acf49fe and various connected issues.
jorisvandenbossche
added a commit
to jorisvandenbossche/shapely
that referenced
this pull request
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent change in numpy main with different semantics for the
copykeyword, wherecopy=Falsewill now guarantee (instead of try) to not make a copy, and thus raise an error when it cannot create the array without allocating data.