Skip to content

Add Python 3.10 wheels for additional platforms#1373

Merged
jorisvandenbossche merged 1 commit intoshapely:mainfrom
adamjstewart:fixes/cp310
Apr 28, 2022
Merged

Add Python 3.10 wheels for additional platforms#1373
jorisvandenbossche merged 1 commit intoshapely:mainfrom
adamjstewart:fixes/cp310

Conversation

@adamjstewart
Copy link
Copy Markdown
Contributor

Forward-port of #1367

@jorisvandenbossche

@adamjstewart
Copy link
Copy Markdown
Contributor Author

Not sure why tests are failing...

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 25, 2022

Pull Request Test Coverage Report for Build 2234197905

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.229%

Totals Coverage Status
Change from base Build 2231284691: 0.0%
Covered Lines: 2131
Relevant Lines: 2530

💛 - Coveralls

@mwtoews
Copy link
Copy Markdown
Member

mwtoews commented Apr 25, 2022

This is the line that causes the failure:

CIBW_TEST_COMMAND: pytest --pyargs pygeos.tests

(arm64 macos-10.15 does not fail due to message "Warning: While arm64 wheels can be built on x86_64, they cannot be tested. The ability to test the arm64 wheels will be added in a future release of cibuildwheel, once Apple Silicon CI runners are widely available.")

This line should probably just CIBW_TEST_COMMAND: pytest

@jorisvandenbossche
Copy link
Copy Markdown
Member

Yeah, there is actually a PR that is fixing up the wheel building the main branch (and eg is fixing that pytest invocation): #1253. I will try to get that merged first.

@jorisvandenbossche
Copy link
Copy Markdown
Member

@adamjstewart I merged #1253, so you should be able to update this.

@adamjstewart
Copy link
Copy Markdown
Contributor Author

Alright, GitHub Actions now passes! Travis CI is still failing, but it's also failing on main.

Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisvandenbossche jorisvandenbossche merged commit 4bc5dfd into shapely:main Apr 28, 2022
@adamjstewart adamjstewart deleted the fixes/cp310 branch April 28, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants