Add Python 3.10 wheels for additional platforms#1367
Merged
jorisvandenbossche merged 2 commits intoshapely:maint-1.8from Apr 25, 2022
Merged
Add Python 3.10 wheels for additional platforms#1367jorisvandenbossche merged 2 commits intoshapely:maint-1.8from
jorisvandenbossche merged 2 commits intoshapely:maint-1.8from
Conversation
Pull Request Test Coverage Report for Build 2216465504
💛 - Coveralls |
Contributor
Author
|
Yay, everything passes! I'm guessing these skips were simply inadvertently copied from pygeos as @jorisvandenbossche surmised. |
mwtoews
approved these changes
Apr 19, 2022
Member
mwtoews
left a comment
There was a problem hiding this comment.
Tests on the new wheels look good!
caspervdw
reviewed
Apr 24, 2022
Collaborator
caspervdw
left a comment
There was a problem hiding this comment.
Thanks for the PR! I noticed that the cp310-manylinux_i686 build is actually building numpy from source. I tend to avoid that situation and leave in the skip for that specific platform.
https://github.com/shapely/shapely/runs/6084981342?check_suite_focus=true#step:8:5601
Contributor
Author
|
Works for me, re-added. |
jorisvandenbossche
approved these changes
Apr 25, 2022
Member
|
Thanks @adamjstewart ! |
Contributor
Author
|
Yep, will do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1348 for discussion.
If this works on maint-1.8 I'll submit the same PR to main.
@kvashchuka @mwtoews @sgillies @jorisvandenbossche