Refactor pickling of LinearRing to not use lgeos#1162
Conversation
|
The windows failure is unrelated (it's also a pickling error, but already existing and related to encoding) |
3f4e2eb to
4437a92
Compare
c7726c9 to
f885cbe
Compare
mwtoews
left a comment
There was a problem hiding this comment.
Changes look good, and great to see the relevant tests pass!
One curious question is why to change the method from __setstate__ to __reduce__? The pickle module docs say:
Although powerful, implementing
__reduce__()directly in your classes is error prone. For this reason, class designers should use the high-level interface (i.e. ...__setstate__()) whenever possible.
(And to reiterate, I'm fine with changing to __reduce__())
4437a92 to
6821fb8
Compare
f885cbe to
27120ac
Compare
|
I am not too familiar with the internal details of pickling, but I know we use |
|
Going to merge this, so I can update #1163 |
xref #988
Together with #1161, this is the last remaining usage of lgeos / ctypes in the shapely-2.0 branch.