Skip to content

[2.0] Remove len() (__len__) for multi-part geometries#1114

Merged
jorisvandenbossche merged 1 commit intoshapely:shapely-2.0from
jorisvandenbossche:shapely-2.0-remove-len-deprecation
Apr 9, 2021
Merged

[2.0] Remove len() (__len__) for multi-part geometries#1114
jorisvandenbossche merged 1 commit intoshapely:shapely-2.0from
jorisvandenbossche:shapely-2.0-remove-len-deprecation

Conversation

@jorisvandenbossche
Copy link
Copy Markdown
Member

@jorisvandenbossche jorisvandenbossche commented Apr 5, 2021

This deprecation in Shapely 1.8 was not yet removed in the shapely-2.0 branch

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.05%) to 77.792% when pulling 7b147be on jorisvandenbossche:shapely-2.0-remove-len-deprecation into 024f75a on Toblerity:shapely-2.0.

Copy link
Copy Markdown
Member

@mwtoews mwtoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and good to modify/rename test_len_raises to check TypeError.

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

Failures are also occuring on the main branch (and opened a PR to address them), so merging this.

@jorisvandenbossche jorisvandenbossche merged commit 9f2015b into shapely:shapely-2.0 Apr 9, 2021
@jorisvandenbossche jorisvandenbossche added this to the 2.0 milestone Apr 9, 2021
@jorisvandenbossche jorisvandenbossche deleted the shapely-2.0-remove-len-deprecation branch April 9, 2021 09:42
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request May 27, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request May 27, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Aug 20, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Sep 30, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants