Skip to content

Clean-up impl: remove impl.py + all helper classes#1052

Merged
jorisvandenbossche merged 2 commits intoshapely:shapely-2.0from
jorisvandenbossche:refactor-remove-impl
Jan 14, 2021
Merged

Clean-up impl: remove impl.py + all helper classes#1052
jorisvandenbossche merged 2 commits intoshapely:shapely-2.0from
jorisvandenbossche:refactor-remove-impl

Conversation

@jorisvandenbossche
Copy link
Copy Markdown
Member

No description provided.

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

One question: the shapely.iterops module provided a set of functions for predicates that could filter an iterable of geometries. Which is something that has no direct replacement.
As far as I know this was not documented, but it was tested (see removed test file), so: is this something we want to explicitly deprecate in Shapely 1.8? (I can still do that on the master branch, no problem) Or does somebody want to keep this functionality? (we could easily reimplement the function with plain shapely geometry methods)

@sgillies
Copy link
Copy Markdown
Contributor

@jorisvandenbossche the objects in the iterops module could be reimplemented by composing existing Python functions and shapely methods, it's true. I'm 👍 on removing it.

@jorisvandenbossche jorisvandenbossche merged commit 34acbc1 into shapely:shapely-2.0 Jan 14, 2021
@jorisvandenbossche jorisvandenbossche deleted the refactor-remove-impl branch January 14, 2021 08:31
@jorisvandenbossche
Copy link
Copy Markdown
Member Author

@sgillies so the shapely.iterops module will be removed in shapely 2.0, but I can still add explicit deprecation warnings for shapely 1.8 about it?

@jorisvandenbossche
Copy link
Copy Markdown
Member Author

It's easy to deprecate, so nice for users to just warn about it -> #1063

jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Apr 5, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Apr 5, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request May 27, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request May 27, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Aug 20, 2021
jorisvandenbossche added a commit to jorisvandenbossche/shapely that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants