Refactor affine_transform: use general function apply on coordinates#1019
Merged
jorisvandenbossche merged 2 commits intoshapely:shapely-2.0from Nov 11, 2020
Merged
Conversation
Member
Author
|
Note that the tests are still failing because |
mwtoews
approved these changes
Nov 11, 2020
Member
mwtoews
left a comment
There was a problem hiding this comment.
Great to see similar performance to the "speedups" implementation and to preserve 3D capabilities, thanks!
jorisvandenbossche
added a commit
to jorisvandenbossche/shapely
that referenced
this pull request
Nov 27, 2020
jorisvandenbossche
added a commit
that referenced
this pull request
Nov 27, 2020
jorisvandenbossche
added a commit
that referenced
this pull request
Nov 27, 2020
jorisvandenbossche
added a commit
to jorisvandenbossche/shapely
that referenced
this pull request
Apr 5, 2021
jorisvandenbossche
added a commit
to jorisvandenbossche/shapely
that referenced
this pull request
Apr 5, 2021
jorisvandenbossche
added a commit
to jorisvandenbossche/shapely
that referenced
this pull request
May 27, 2021
jorisvandenbossche
added a commit
to jorisvandenbossche/shapely
that referenced
this pull request
May 27, 2021
jorisvandenbossche
added a commit
to jorisvandenbossche/shapely
that referenced
this pull request
Aug 20, 2021
jorisvandenbossche
added a commit
that referenced
this pull request
Aug 21, 2021
jorisvandenbossche
added a commit
to jorisvandenbossche/shapely
that referenced
this pull request
Sep 30, 2021
jorisvandenbossche
added a commit
that referenced
this pull request
Oct 27, 2021
jorisvandenbossche
added a commit
that referenced
this pull request
Oct 28, 2021
jorisvandenbossche
added a commit
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In pygeos, we have a general
applymethod to apply a function on the coordinates and recreate geometries from those transformed geometries (we probably need to rename it to transform, but that's another issue).This speeds up the affine transforms again a bit (which saw a slowdown in #983). The specific example of #983 (comment) is now again at the same speed as with released Shapely:
Now, for single geometries, I don't think we need to expect speed-ups, certainly not compared to the cython code (that I removed here).