add SetDecodedTimeAsUTC / SetDecodedTimeAsLocal; update README Announcement#52
Merged
add SetDecodedTimeAsUTC / SetDecodedTimeAsLocal; update README Announcement#52
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 98.51% 99.18% +0.67%
==========================================
Files 71 72 +1
Lines 6736 6766 +30
==========================================
+ Hits 6636 6711 +75
+ Misses 77 42 -35
+ Partials 23 13 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shamaton
added a commit
that referenced
this pull request
Feb 4, 2026
add SetDecodedTimeAsUTC / SetDecodedTimeAsLocal; update README Announcement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (Breaking Change)
This PR changes the default
Locationused when decoding MessagePack Timestamp into Go’stime.TimefromLocaltoUTC. The encoded/decoded instant is unchanged (MessagePack Timestamp stores seconds+nanos only); onlytime.Time.Location()differs.Closes #51.
Motivation & Background
Localby default leads to environment-dependent results (different hosts show different zones) and surprises in distributed systems/APIs.What’s in this PR
Default behavior (v3): Decoded
time.Timeis now UTC by default.Global switches (new):
msgpack.SetDecodedTimeAsUTC()– force decodedtime.Timeto useUTC(v3 default).msgpack.SetDecodedTimeAsLocal()– force decodedtime.Timeto useLocal(restores v2-like behavior).Docs:
Public API (surface)
Migration Guide (short)
If you need the old behavior (Local):
Recommended for distributed systems/APIs: keep or explicitly set the new UTC default: